[HUDI-7438] Reimplement Azure CI report check with open PRs #10746
+197
−51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
This PR redesigns and implements the way of surfacing Azure CI report status of a PR and fixes bugs in checking Azure CI report based on
issue_comment
event triggers.There are a few things to be aware of:
yihua/hudi
instead ofapache/hudi
) has read-only permissions, and no write permissions are granted (Apache restriction). Only the GitHub workflows triggered from master and branches onapache/hudi
contain GitHub token with write permissions, including scheduled tasks and workflows triggered by issue/PR comments. Write permissions are required for creating commit status, commenting on the PR, adding labels to the PR, add related projects, etc.hudi-bot
user. Such comments are put by the bot some time after the PR is created.issue_comment
, e.g., PR comments, is not associated with the PR, so from the PR page, we cannot directly see the workflow result, whether the check is successful or not.This PR aims to create a commit status to the PR (see sample screenshots below) and maintain that based on the Azure CI report so it's easier to check the Azure CI status. Changes are:
pull_request
event-triggered workflows do not have write permissions, a new scheduled workflow, which has write permissions, is created inscheduled_workflow.yml
to run every 5 minutes to check on recently created and updated PRs, and create or update commit status for Azure CI to the corresponding PR.azure_ci_checks.yml
is fixed to also create or update the commit status of the corresponding PR based on the Azure CI report status.HOTFIX: SKIP AZURE CI
magic phrase in the description, are skipped for the check.How the commit status looks like in the PR:
The "Details" links to the Azure CI run.
Azure CI pending
Azure CI failing
Azure CI success
The core logic implemented is tested in a pushed branch to
apache/hudi
with this PR since we cannot test the logic from a fork: #10743.Impact
Makes Azure CI status easy to read.
Risk level
none
Documentation Update
N/A
Contributor's checklist